[webkit-reviews] review denied: [Bug 67980] [Chromium/Mac] fast/events/constructors/progress-event-constructor.html is failing : [Attachment 112631] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 2 10:32:00 PDT 2011
MORITA Hajime <morrita at google.com> has denied Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 67980: [Chromium/Mac]
fast/events/constructors/progress-event-constructor.html is failing
https://bugs.webkit.org/show_bug.cgi?id=67980
Attachment 112631: Patch
https://bugs.webkit.org/attachment.cgi?id=112631&action=review
------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112631&action=review
> Source/JavaScriptCore/wtf/MathExtras.h:297
> +inline void doubleToInteger(double d, unsigned long long& value)
Why not return value? That can remove all else clauses.
More information about the webkit-reviews
mailing list