[webkit-reviews] review granted: [Bug 71364] CSSStyleRule: Devirtualize selectorText() : [Attachment 113314] Purposeful patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 71364: CSSStyleRule: Devirtualize selectorText()
https://bugs.webkit.org/show_bug.cgi?id=71364

Attachment 113314: Purposeful patch
https://bugs.webkit.org/attachment.cgi?id=113314&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=113314&action=review


r=me

> Source/WebCore/css/CSSStyleRule.cpp:50
>  String CSSStyleRule::selectorText() const
>  {
> +    if (isPageRule())
> +	   return static_cast<CSSPageRule*>(this)->selectorText();

It would be less confusing if the subclass function had a different name
(pageSelectorText() perhaps?).