[webkit-reviews] review granted: [Bug 65522] Optimizing arithmetic composite filter to ARM-neon SIMD instruction set : [Attachment 112165] patch again

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 65522: Optimizing arithmetic composite filter to ARM-neon SIMD instruction
set
https://bugs.webkit.org/show_bug.cgi?id=65522

Attachment 112165: patch again
https://bugs.webkit.org/attachment.cgi?id=112165&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112165&action=review


LGTM. I can just trust you on the Neon code. Just some snippets.

> Source/WebCore/ChangeLog:12
> +	   for all four RGBA channels in the same time.

at the same time?

> Source/WebCore/ChangeLog:13
> +

Just mention that it won't affect the general behavior and existing tests will
cover the changes.

> Source/WebCore/platform/graphics/filters/FEComposite.cpp:123
> -    float scaledK4;
> -    float scaledK1;
> +    float scaledK1, scaledK4;

that is not allowed according the webkit style rules. Just leave it as it was.

> Source/WebCore/platform/graphics/filters/FEComposite.cpp:180
> +    ASSERT(!(pixelArrayLength & 0x3));

where is pixelArrayLength?