[webkit-reviews] review denied: [Bug 71342] [Mac] _drt_descriptionSuitableForTestResult generate an exception for absolute paths above the main frame : [Attachment 113266] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 1 17:50:07 PDT 2011
Darin Adler <darin at apple.com> has denied Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 71342: [Mac] _drt_descriptionSuitableForTestResult generate an exception
for absolute paths above the main frame
https://bugs.webkit.org/show_bug.cgi?id=71342
Attachment 113266: Patch
https://bugs.webkit.org/attachment.cgi?id=113266&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113266&action=review
>>
LayoutTests/webarchive/loading/test-loading-archive-subresource-null-mimetype-e
xpected.txt:12
>> +file:///test.png - didReceiveResponse <NSURLResponse
file:///Users/pecoraro/Desktop/test.png, http status code 0>
>
> That's not good. It has the patch of a user’s home directory!
The path of a specific users’s home directory. We can}t have that in expected
test results.
More information about the webkit-reviews
mailing list