[webkit-reviews] review granted: [Bug 71254] Amend missing uses of LayoutUnit in RenderBlock : [Attachment 113259] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 71254: Amend missing uses of LayoutUnit in RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=71254

Attachment 113259: Patch
https://bugs.webkit.org/attachment.cgi?id=113259&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113259&action=review


Is numeric_limits<LayoutUnit>::max() ever actually the right/helpful value for
LayoutUnit other than int?

> Source/WebCore/rendering/RenderBlock.cpp:2503
> +    // We don't want to had off painting in the line box tree with the
accumulated error of the render tree, as this will cause

"had off"?