[webkit-reviews] review granted: [Bug 71324] Expand DragController to provide more information about the dragging session : [Attachment 113254] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jon Lee <jonlee at apple.com>'s request
for review:
Bug 71324: Expand DragController to provide more information about the dragging
session
https://bugs.webkit.org/show_bug.cgi?id=71324

Attachment 113254: Patch
https://bugs.webkit.org/attachment.cgi?id=113254&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113254&action=review


> Source/WebCore/page/DraggingInfo.h:33
> +struct DraggingInfo {

I’m usually not such a big fan of “info” in a class name, since everything in a
computer is info or data, and that suffix doesn’t add much.

> Source/WebCore/page/DraggingInfo.h:39
> +    bool mouseOverFileInput;

I think a verb in this phrase would help. Like “mouseIsOverFileInput”.