[webkit-reviews] review requested: [Bug 71082] [Qt][WK2] Implement favicon support : [Attachment 113256] Adds basic implementation for showing favicons on QML and cleaning up the icon database.

[bugzilla-daemon at webkit.org]

Rafael Brandao <rafael.lobo at openbossa.org> has asked  for review:
Bug 71082: [Qt][WK2] Implement favicon support
https://bugs.webkit.org/show_bug.cgi?id=71082

Attachment 113256: Adds basic implementation for showing favicons on QML and
cleaning up the icon database.
https://bugs.webkit.org/attachment.cgi?id=113256&action=review

------- Additional Comments from Rafael Brandao <rafael.lobo at openbossa.org>
Currently a Favicon component needs to target a DesktopWebView so it can fetch
the data for its url whenever it changes. The data is stored by
WebIconDatabase, and it's using the default icon database path for now. I had
to change the visibility of WebContext::iconDatabasePath so I could use it when
I'm doing the setup for QtWebIconDatabase. I wonder if there's a way (probably
there is) to use it without this change, but I couldn't think of anything more
practical right now. Its setup is done when we create the single WebContext.
It's destroyed when that WebContext is destroyed. Here's an example of usage on
QML:

Favicon {
    id: favicon
    webView: pageWidget.webView
    width: 16
    height: 16
    MouseArea {
	anchors.fill: parent
	onClicked: favicon.removeAllIcons()
    }
}