[webkit-reviews] review granted: [Bug 71334] Small fixes for WebVTTParser : [Attachment 113246] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anna Cavender <annacc at chromium.org>'s
request for review:
Bug 71334: Small fixes for WebVTTParser
https://bugs.webkit.org/show_bug.cgi?id=71334

Attachment 113246: Patch
https://bugs.webkit.org/attachment.cgi?id=113246&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113246&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests.  This is needed to enable other tests, coming soon.

OK. I’m going to hold you to that one!

> Source/WebCore/html/track/WebVTTParser.cpp:193
> -    if (line[position++] != ' ' && line[position++] != '\t')
> +    if (line[position] != ' ' && line[position] != '\t')

What guarantees we are not at the end of the line here?

By the way, I think the ++ was OK, but not two different ++. A local variable
would have been another way to do it.

> Source/WebCore/html/track/WebVTTParser.cpp:201
> -    if (line[position++] != ' ' && line[position++] != '\t')
> +    if (line[position] != ' ' && line[position] != '\t')

Same question/comment.