[webkit-reviews] review denied: [Bug 42131] WebKitTestRunner needs to support accessibility-related DRT APIs : [Attachment 113195] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied chris fleizach <cfleizach at apple.com>'s
request for review:
Bug 42131: WebKitTestRunner needs to support accessibility-related DRT APIs
https://bugs.webkit.org/show_bug.cgi?id=42131

Attachment 113195: patch
https://bugs.webkit.org/attachment.cgi?id=113195&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113195&action=review


> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm:-499
> -    ASSERT(!value.isEmpty());
> -    

You can’t just remove this assert. The call to get below won’t work right with
certain values (either null strings or empty strings, I can’t recall which)
because of how hash tables work. If you need to allow these strings, then you
need to add an explicit early return, not fall through to the hash table code.

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:71
> +WK_EXPORT void* WKAccessibilityRootObject(WKBundlePageRef);
> +WK_EXPORT void* WKAccessibilityFocusedObject(WKBundlePageRef);    

Does this really need to be void*?