[webkit-reviews] review granted: [Bug 70951] IDL constants can't use [Reflect] : [Attachment 113223] fixing = typo and adding better description in changelog

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anna Cavender <annacc at chromium.org>'s
request for review:
Bug 70951: IDL constants can't use [Reflect]
https://bugs.webkit.org/show_bug.cgi?id=70951

Attachment 113223: fixing = typo and adding better description in changelog
https://bugs.webkit.org/attachment.cgi?id=113223&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113223&action=review


> Source/WebCore/html/TextTrack.idl:46
> +	   const [Reflect=None] unsigned short NONE = 0;
> +	   const [Reflect=Loading] unsigned short LOADING = 1;
> +	   const [Reflect=Loaded] unsigned short LOADED = 2;
> +	   const [Reflect=Error] unsigned short ERROR = 3;
>	   readonly attribute unsigned short readyState;
>  
> -	   const [Reflect=DISABLED] unsigned short Disabled = 0;
> -	   const [Reflect=HIDDEN] unsigned short Hidden = 1;
> -	   const [Reflect=SHOWING] unsigned short Showing = 2;
> +	   const [Reflect=Disabled] unsigned short DISABLED = 0;
> +	   const [Reflect=Hidden] unsigned short HIDDEN = 1;
> +	   const [Reflect=Showing] unsigned short SHOWING = 2;

Given that ERROR is the one that conflicts, do we need to rename all the
others?