[webkit-reviews] review denied: [Bug 62159] Implement montonicallyIncreasingClock() on Qt : [Attachment 97221] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 1 14:45:41 PDT 2011


Simon Hausmann <hausmann at webkit.org> has denied Jason
<liuyang12341982 at 163.com>'s request for review:
Bug 62159: Implement montonicallyIncreasingClock() on Qt
https://bugs.webkit.org/show_bug.cgi?id=62159

Attachment 97221: Patch
https://bugs.webkit.org/attachment.cgi?id=97221&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I agree with the two gentlemen :). Could you implement this using
QElapsedTimer?

Plus there's something wrong in the function declaration. From what I can tell
from the CurrentTime.cpp the patch should look something like this:

+#elif PLATFORM(QT)
+
+double monotonicallyIncreasingClock()
+{
...
+}
+
#else


More information about the webkit-reviews mailing list