[webkit-reviews] review denied: [Bug 61941] [Qt] LayoutTests/fast/dom/Window/new-window-opener.html failed : [Attachment 95775] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 1 14:31:40 PDT 2011


Simon Hausmann <hausmann at webkit.org> has denied qi <qi.2.zhang at nokia.com>'s
request for review:
Bug 61941: [Qt] LayoutTests/fast/dom/Window/new-window-opener.html failed
https://bugs.webkit.org/show_bug.cgi?id=61941

Attachment 95775: patch
https://bugs.webkit.org/attachment.cgi?id=95775&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I agree with the other folks. It sounds like the implementation of these two
functions in ChromeClientQt should use FrameView's setCanHaveScrollbars and
canHaveScrollbars. Check out the windows port for inspiration :)

I don't think new API is required.


More information about the webkit-reviews mailing list