[webkit-reviews] review denied: [Bug 71309] Allow SVG elements to be transformed using webkit-transform : [Attachment 113204] Proposed patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Raul Hudea <rhudea at adobe.com>'s
request for review:
Bug 71309: Allow SVG elements to be transformed using webkit-transform
https://bugs.webkit.org/show_bug.cgi?id=71309

Attachment 113204: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=113204&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
You're missing the changelogs. Also, why haven't you changed SVGTextElement as
well? r-

Even so, I disagree with the implementation in general. I'd implement
'transform' as a CSS property and the transform attribute would be mapped to
the CSS property. I don't believe that this solution would help us a lot. Of
course this needs more harmonization with the CSS parser and SVG DOM. I'd start
rather with the CSS parser than with a separate implementation of 'transform'
attr and  '-webkit-transform'.
Just see the following example to understand what I mean. The CSS property has
the value of the attribute:

<svg xmlns="http://www.w3.org/2000/svg" onload="start()">
<script type="text/ecmascript"><![CDATA[
function start() {
var e = document.getElementsByTagName('text')[0];
var c = window.getComputedStyle(e, null);
alert(c.getPropertyCSSValue('display').cssText);
}
]]></script>
<text x="40" y="40" display="none">ABC</text>
</svg>