[webkit-reviews] review granted: [Bug 71295] [Qt][WK2] Make API tests less noisy : [Attachment 113194] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 1 10:58:16 PDT 2011
Simon Hausmann <hausmann at webkit.org> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 71295: [Qt][WK2] Make API tests less noisy
https://bugs.webkit.org/show_bug.cgi?id=71295
Attachment 113194: proposed patch
https://bugs.webkit.org/attachment.cgi?id=113194&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113194&action=review
r=me but add the missing "static" keyword when landing I'd say :)
> Source/WebKit2/UIProcess/API/qt/tests/util.cpp:53
> +void messageHandler(QtMsgType type, const char* message)
This method should be static.
More information about the webkit-reviews
mailing list