[webkit-reviews] review granted: [Bug 69425] display: table-cell always uses content-box sizing to calculate height, even when box-sizing: border-box : [Attachment 109927] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Dominic Cooney <dominicc at chromium.org>'s request
for review:
Bug 69425: display: table-cell always uses content-box sizing to calculate
height, even when box-sizing: border-box
https://bugs.webkit.org/show_bug.cgi?id=69425

Attachment 109927: Patch
https://bugs.webkit.org/attachment.cgi?id=109927&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=109927&action=review


> Source/WebCore/rendering/RenderTableSection.cpp:373
> +		   // In strict mode, box-sizing: content-box do the
> +		   // right thing and actually add in the border and
> +		   // padding.

This comment can fit on two lines (or maybe even one line).

> Source/WebCore/rendering/RenderTableSection.cpp:376
> +		   ch += (adjustedPaddingBefore + adjustedPaddingAfter +
cell->borderBefore() + cell->borderAfter());

The parentheses seem unnecessary.