[webkit-reviews] review granted: [Bug 71246] REGRESSION(98738): RenderTableSection::recalcCells does not properly shrink the RowStruct grid : [Attachment 113190] Proposed change 2: With a better ChangeLog and description.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 1 10:36:07 PDT 2011


Darin Adler <darin at apple.com> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 71246: REGRESSION(98738): RenderTableSection::recalcCells does not properly
shrink the RowStruct grid
https://bugs.webkit.org/show_bug.cgi?id=71246

Attachment 113190: Proposed change 2: With a better ChangeLog and description.
https://bugs.webkit.org/attachment.cgi?id=113190&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113190&action=review


> Source/WebCore/rendering/RenderTableSection.cpp:1152
> +    m_grid.shrink(gridSize);

What guarantees this is a shrink? Is there ever a chance that gridSize could be
larger than m_grid.size() at this point?


More information about the webkit-reviews mailing list