[webkit-reviews] review denied: [Bug 71295] [Qt][WK2] Make API tests less noisy : [Attachment 113181] proposed patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 71295: [Qt][WK2] Make API tests less noisy
https://bugs.webkit.org/show_bug.cgi?id=71295

Attachment 113181: proposed patch
https://bugs.webkit.org/attachment.cgi?id=113181&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113181&action=review


r- due to style :). Looks good otherwise.

> Source/WebKit2/UIProcess/API/qt/tests/util.h:33
> +#define SUPPRESS_DEBUG_OUTPUT \

Style guide says that this macro should be named like a function and have
parentheses at the end. But ... why not simply make it an actual function
that's implemented in util.cpp? (instead of "exporting" messageHandler)