[webkit-reviews] review granted: [Bug 71285] CSSRule: Devirtualize addSubresourceStyleURLs() : [Attachment 113171] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 71285: CSSRule: Devirtualize addSubresourceStyleURLs()
https://bugs.webkit.org/show_bug.cgi?id=71285

Attachment 113171: Patch
https://bugs.webkit.org/attachment.cgi?id=113171&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=113171&action=review


r=me

> Source/WebCore/css/CSSStyleRule.h:59
> -    virtual void addSubresourceStyleURLs(ListHashSet<KURL>& urls);
> +    void addSubresourceStyleURLs(ListHashSet<KURL>& urls);

Something like collectSubresourceURLSs would be a better name and the function
should be const. For future refactoring as the name is used in many places.