[webkit-reviews] review granted: [Bug 71284] [skia] call readPixels on canvas instead of device (will be private on device soon) and check for error : [Attachment 113166] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 1 06:56:12 PDT 2011
Stephen White <senorblanco at chromium.org> has granted Mike Reed
<reed at google.com>'s request for review:
Bug 71284: [skia] call readPixels on canvas instead of device (will be private
on device soon) and check for error
https://bugs.webkit.org/show_bug.cgi?id=71284
Attachment 113166: Patch
https://bugs.webkit.org/attachment.cgi?id=113166&action=review
------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113166&action=review
OK. r=me
> Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:239
> unsigned destBytesPerRow = 4 * rect.width();
Nit: This line could be moved below the readPixels() call (not new to this
patch, though).
More information about the webkit-reviews
mailing list