[webkit-reviews] review granted: [Bug 61574] Switch MouseRelatedEvent to use IntPoint : [Attachment 95511] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 31 19:28:35 PDT 2011
Eric Seidel <eric at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 61574: Switch MouseRelatedEvent to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61574
Attachment 95511: Patch
https://bugs.webkit.org/attachment.cgi?id=95511&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95511&action=review
> Source/WebCore/dom/WheelEvent.cpp:46
> + , m_wheelDelta(IntPoint((int)(wheelTicks.x() * 120),
(int)(wheelTicks.y() * 120)))
c++ casts, not c. :)
> Source/WebCore/platform/graphics/IntPoint.h:99
> + m_x = lroundf((float)m_x * sx);
> + m_y = lroundf((float)m_y * sy);
Again, c++, not c. Otherwise fine.
More information about the webkit-reviews
mailing list