[webkit-reviews] review granted: [Bug 7169] Support exporting of MHTML web archives : [Attachment 95512] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Jay Civelli
<jcivelli at chromium.org>'s request for review:
Bug 7169: Support exporting of MHTML web archives
https://bugs.webkit.org/show_bug.cgi?id=7169

Attachment 95512: Patch
https://bugs.webkit.org/attachment.cgi?id=95512&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95512&action=review

Looks good to me, but give Alexey a chance to take another look.

> Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp:132
> +	   tm* timeAndDate = gmtime(&(timeValue.tv_sec));

Sorry for the dumb question, but do we need to free timeAndDate?

> Source/WebKit/chromium/src/WebPageSerializer.cpp:208
> +    WebFrame* webFrame = static_cast<WebViewImpl*>(view)->mainFrame();
> +    Frame* frame = static_cast<WebFrameImpl*>(webFrame)->frame();
> +    RefPtr<SharedBuffer> mhtml =
MHTMLArchive::generateMHTMLData(frame->page());

There's no way to get directly from a WebViewImpl to a Page?