[webkit-reviews] review granted: [Bug 61738] compilation fails with libpng-1.5 : [Attachment 95363] Updated libpng15 patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 31 15:45:09 PDT 2011


Alexey Proskuryakov <ap at webkit.org> has granted Christoph Mende
<angelos at gentoo.org>'s request for review:
Bug 61738: compilation fails with libpng-1.5
https://bugs.webkit.org/show_bug.cgi?id=61738

Attachment 95363: Updated libpng15 patch
https://bugs.webkit.org/attachment.cgi?id=95363&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95363&action=review

> WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

Commit queue can't land the patch with this line. You should just remove it, as
it's obvious why no test is needed.

> WebCore/ChangeLog:11
> +	   * platform/image-encoders/skia/PNGImageEncoder.cpp:
> +	   (WebCore::writeOutput): Use the new API

As you explained in Bugzilla, the API is not new.


More information about the webkit-reviews mailing list