[webkit-reviews] review granted: [Bug 61802] [Qt][WK2] Add QGLWidget viewport support to MiniBrowser : [Attachment 95476] Fix style problem

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Viatcheslav Ostapenko
<ostapenko.viatcheslav at nokia.com>'s request for review:
Bug 61802: [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=61802

Attachment 95476: Fix style problem
https://bugs.webkit.org/attachment.cgi?id=95476&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95476&action=review

r=me

At some point we should probably make that simply the default...

> Tools/MiniBrowser/qt/BrowserView.cpp:49
> +	   setViewport(new QGLWidget());

Nitpick, here you use new GLWidget() and further down just "new QGLWidget"

> Tools/MiniBrowser/qt/BrowserView.cpp:76
> +void BrowserView::toggleGLViewport(bool useQGLWidgetViewport)
> +{
> +#if defined(QT_CONFIGURED_WITH_OPENGL)
> +    setViewport(useQGLWidgetViewport ? new QGLWidget : 0);
> +#endif
> +}

setViewport is a public method, so this code doesn't actually have to live in
BrowserView but could also be done from the outside.