[webkit-reviews] review denied: [Bug 61801] Add Glade catalog for WebKitGTK widgets : [Attachment 95470] first implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 31 13:48:03 PDT 2011


Gustavo Noronha (kov) <gns at gnome.org> has denied Juan Pablo Ugarte
<juanpablougarte at gmail.com>'s request for review:
Bug 61801: Add Glade catalog for WebKitGTK widgets
https://bugs.webkit.org/show_bug.cgi?id=61801

Attachment 95470: first implementation
https://bugs.webkit.org/attachment.cgi?id=95470&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Hey, thanks for working on this! I don't know a lot about glade catalogs but
I'll try to review this patch. Before I go into details though I'd like to ask
you to review the style guide http://www.webkit.org/coding/coding-style.html.
The names and declaration locations of variables, the position of the *, the
sorting of #include statements, position of bracers are all wrong on the .c
file (which, I think should be called webkitglade.c or gladewebkit.c to be
consistent with the rest of the files under Sources/WebKit/gtk).

We also need a ChangeLog entry that you can generate with the
Tools/Scripts/prepare-ChangeLog  script (use --help to see the relevant
options).


More information about the webkit-reviews mailing list