[webkit-reviews] review granted: [Bug 34314] Add a test for FrameLoaderClient::allowImages : [Attachment 95408] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 34314: Add a test for FrameLoaderClient::allowImages
https://bugs.webkit.org/show_bug.cgi?id=34314

Attachment 95408: Patch
https://bugs.webkit.org/attachment.cgi?id=95408&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95408&action=review

> LayoutTests/platform/chromium/permissionclient/image-permissions.html:24
> +    img.src = "resources/boston2.gif";

You don't actually need a separate image.  You can just use a query parameter. 
We have a bunch of images you can use for tests already.  Do we the rights to
the image you're adding?

> Tools/DumpRenderTree/chromium/WebPermissions.cpp:36
> +WebPermissions::WebPermissions()
> +    : m_imagesAllowed(true)
> +    , m_storageAllowed(true)

Should this just call reset() ?

> Tools/DumpRenderTree/chromium/WebPermissions.cpp:52
> +bool WebPermissions::allowImages(WebKit::WebFrame*, bool enabledPerSettings)

> +{
> +    return enabledPerSettings && m_imagesAllowed;
> +}
> +
> +bool WebPermissions::allowStorage(WebKit::WebFrame*, bool)
> +{
> +    return m_storageAllowed;
> +}

Why doesn't allowStorage use enabledPerSettings as well?