[webkit-reviews] review granted: [Bug 61791] [GTK] Provide custom DOM bindings methods to check if input/textareas have been edited : [Attachment 95450] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 61791: [GTK] Provide custom DOM bindings methods to check if
input/textareas have been edited
https://bugs.webkit.org/show_bug.cgi?id=61791

Attachment 95450: Patch
https://bugs.webkit.org/attachment.cgi?id=95450&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95450&action=review

>> Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp:29
>> +gboolean
webkit_dom_html_text_area_element_is_edited(WebKitDOMHTMLTextAreaElement* area)

> 
> webkit_dom_html_text_area_element_is_edited is incorrectly named. Don't use
underscores in your identifier names.  [readability/naming] [4]

Why not webkit_dom_html_text_area_element_last_change_was_user_edit?