[webkit-reviews] review requested: [Bug 55481] Consider padding and border when looking for the next/previous line position : [Attachment 95435] Patch proposal + Layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 31 08:22:58 PDT 2011


Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 55481: Consider padding and border when looking for the next/previous line
position
https://bugs.webkit.org/show_bug.cgi?id=55481

Attachment 95435: Patch proposal + Layout test
https://bugs.webkit.org/attachment.cgi?id=95435&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #17)
> (From update of attachment 91904 [details])
> Your ChangeLog looks confused.  You have mutiple nested entries. 
> There should only be one entry.

Oops... sorry, it's fixed now.

(In reply to comment #18)
> (From update of attachment 91904 [details])
> I assume this is only visible when using caret browsing mode?  Your patch no
> longer applies so I can't see the context, to see if these functions are
> caret-browsing-only.

The patch applies now.


More information about the webkit-reviews mailing list