[webkit-reviews] review granted: [Bug 61739] [Qt] Rewrite tst_QDeclarativeWebView::multipleWindows() to not depend on Grid internals : [Attachment 95356] Patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 61739: [Qt] Rewrite tst_QDeclarativeWebView::multipleWindows() to not
depend on Grid internals
https://bugs.webkit.org/show_bug.cgi?id=61739

Attachment 95356: Patch
https://bugs.webkit.org/attachment.cgi?id=95356&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95356&action=review

lgtm, a few comments:

> Source/WebKit/qt/tests/qdeclarativewebview/resources/newwindows.qml:-9
> -    height: 300; width: 600

Don't split this, it just adds to the diff for no reason.

> Source/WebKit/qt/tests/qdeclarativewebview/resources/newwindows.qml:30
> +			   firstPageOpened = thisPage;

pages.firstPageOpened