[webkit-reviews] review denied: [Bug 61743] [Qt] LayoutTests/fast/canvas/webgl/renderbuffer-initialization.html fails for Qt based webkit : [Attachment 95367] Patch for the fix.

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Idrees <sidreesshah at hotmail.com>'s
request for review:
Bug 61743: [Qt] LayoutTests/fast/canvas/webgl/renderbuffer-initialization.html
fails for Qt based webkit
https://bugs.webkit.org/show_bug.cgi?id=61743

Attachment 95367: Patch for the fix.
https://bugs.webkit.org/attachment.cgi?id=95367&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95367&action=review

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:554
> +

One newline is enough.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:596
> +    if (m_attrs.depth) {
> +	       glClearDepth(clearDepth);
> +	       glDepthMask(depthMask);
> +	   }
> +	   if (m_attrs.stencil) {
> +	       glClearStencil(clearStencil);
> +	       stencilMaskSeparate(GraphicsContext3D::FRONT, stencilMask);
> +	   }
> +	   if (isScissorEnabled)
> +	       glEnable(GraphicsContext3D::SCISSOR_TEST);
> +	   if (isDitherEnabled)
> +	       glEnable(GraphicsContext3D::DITHER);
> +

Wrong indentation.