[webkit-reviews] review granted: [Bug 61727] Add a utility function which dumps a tree for the Node, including a document of a frame. : [Attachment 95398] Addressed the review comments.

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Hayato Ito <hayato at chromium.org>'s
request for review:
Bug 61727: Add a utility function which dumps a tree for the Node, including a
document of a frame.
https://bugs.webkit.org/show_bug.cgi?id=61727

Attachment 95398: Addressed the review comments.
https://bugs.webkit.org/attachment.cgi?id=95398&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95398&action=review

> Source/WebCore/dom/Node.cpp:2387
> +ContainerNode* Node::parentOrHostOrFrameOwner() const
> +{
> +    ContainerNode* parent = parentOrHostNode();
> +    if (!parent && document() && document()->frame())
> +	   parent = document()->frame()->ownerElement();
> +    return parent;
> +}
> +
> +Node* Node::traverseNextNodeAcrossFrame() const

On my second thought, these functions don't even need to be member functions
since they don't access any private functions / variables and are only used by
showTreeForThisAcrossFrame.  Please make them static local functions before you
land.