[webkit-reviews] review granted: [Bug 61759] [Chromium] Make isValidProtocol() accept protocols with '+'. : [Attachment 95396] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted James Kozianski
<koz at chromium.org>'s request for review:
Bug 61759: [Chromium] Make isValidProtocol() accept protocols with '+'.
https://bugs.webkit.org/show_bug.cgi?id=61759

Attachment 95396: Patch
https://bugs.webkit.org/attachment.cgi?id=95396&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95396&action=review

> Source/WebCore/ChangeLog:11
> +	   [Chromium] Make isValidProtocol() accept protocols with '+'.
> +
> +	   Also, detect syntax errors before security errors; some syntax
errors
> +	   will also trigger a security error, but it's more helpful to the
> +	   programmer to know if they have a syntax error, which are
well-defined
> +	   in the spec, rather than a security error, which aren't.
> +	   https://bugs.webkit.org/show_bug.cgi?id=61759

nit: Usually we use the order of 
 <One-line summary>
 <Bug URL>

 <Description>