[webkit-reviews] review denied: [Bug 61759] [Chromium] Make isValidProtocol() accept protocols with '+'. : [Attachment 95395] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied James Kozianski
<koz at chromium.org>'s request for review:
Bug 61759: [Chromium] Make isValidProtocol() accept protocols with '+'.
https://bugs.webkit.org/show_bug.cgi?id=61759

Attachment 95395: Patch
https://bugs.webkit.org/attachment.cgi?id=95395&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95395&action=review

> Source/WebCore/ChangeLog:10
> +	   Detect syntax errors before security errors.

Could you write reasons why we need to detect syntax errors earlier?

> Source/WebCore/ChangeLog:15
> +2011-05-30  James Kozianski	<koz at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [Chromium] Make isValidProtocol() accept protocols with '+'.
> +	   https://bugs.webkit.org/show_bug.cgi?id=61759
> +
> +	   * page/Navigator.cpp:
> +	   (WebCore::Navigator::registerProtocolHandler):
> +	   Detect syntax errors before security errors.
> +	   * platform/KURLGoogle.cpp:
> +	   (WebCore::isSchemeChar):
> +	   Include '+' in the list of valid characters.
> +
> +2011-05-30  James Kozianski	<koz at chromium.org>

Teere are two ChangeLog entries.