[webkit-reviews] review granted: [Bug 61756] Flash of black at the end of full screen transition at apple.com product videos : [Attachment 95390] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 30 20:28:33 PDT 2011


Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 61756: Flash of black at the end of full screen transition at apple.com
product videos
https://bugs.webkit.org/show_bug.cgi?id=61756

Attachment 95390: Patch
https://bugs.webkit.org/attachment.cgi?id=95390&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95390&action=review

OK.

> Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:156
>	   if (m_rootLayer) {

The null check for m_rootLayer seems a little strange given that the code you
are moving was already dereferencing m_rootLayer before this. I’m guessing this
null check is not needed (but not saying you should take it out right now).

> Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:159
>	       [CATransaction begin];
>	       PlatformLayer* rootPlatformLayer = m_rootLayer->platformLayer();

> +	       [[NSNotificationCenter defaultCenter]
postNotificationName:@"WebKitLayerHostChanged" object:rootPlatformLayer
userInfo:nil];

Is it really a good idea to send the notification after beginning the CA
transaction? Is there any harm to making the CATransaction method call
afterward?


More information about the webkit-reviews mailing list