[webkit-reviews] review denied: [Bug 61755] Page layout messed up after exiting full screen at Apple trailers page : [Attachment 95388] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 61755: Page layout messed up after exiting full screen at Apple trailers
page
https://bugs.webkit.org/show_bug.cgi?id=61755

Attachment 95388: Patch
https://bugs.webkit.org/attachment.cgi?id=95388&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95388&action=review

> Source/WebCore/ChangeLog:11
> +	   Incomplete implementation of r87660.  Exiting full screen must set
the "containsFullScreenElement" 
> +	   flag of every element in the full screen element's ancestors, not
just the document's owner.

This doesn’t make sense. Why would we do anything with the document’s
ownerElement? That’s the <object> or <iframe> element in the parent document
that owns this document in the case of a subframe.

And why is starting with the full-screen element’s parent right? What about its
grandparent? Or further up in the document?