[webkit-reviews] review requested: [Bug 51099] [Qt] QWebPagePrivate::inputMethodEvent has problem when compositing Korean : [Attachment 95382] Patch

[bugzilla-daemon at webkit.org]

Hwang <luxtella at company100.net> has asked  for review:
Bug 51099: [Qt] QWebPagePrivate::inputMethodEvent has problem when compositing
Korean
https://bugs.webkit.org/show_bug.cgi?id=51099

Attachment 95382: Patch
https://bugs.webkit.org/attachment.cgi?id=95382&action=review

------- Additional Comments from Hwang <luxtella at company100.net>
I changed the approach.

Qt document said QInputMethodEvent::Cursor's zero length means invisible.
http://web.mit.edu/qt-dynamic/www/qinputmethodevent.html
I think it make sense that the caret is invisible when compositing single text
that the underline marks compositing here.
If multi-texts are being composited like Arabic, it is necessary for caret to
mark where is compositing.

Although the caret became invisible due to composition, the caret should be
visible after composition.