[webkit-reviews] review granted: [Bug 57850] [Qt][WK2] Qt port needs test content for QWKHistory : [Attachment 94638] Updated patch addressing review comments

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Jamie Cooley
<james.cooley at nokia.com>'s request for review:
Bug 57850: [Qt][WK2] Qt port needs test content for QWKHistory
https://bugs.webkit.org/show_bug.cgi?id=57850

Attachment 94638: Updated patch addressing review comments
https://bugs.webkit.org/attachment.cgi?id=94638&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94638&action=review

I had a quick look, the test looks good.
Just replace all the comparison based on url().toString() to just comparison of
the url directly.

You should ping reviewers when a patch waits forever. I totally forgot about
this.

> Source/WebKit2/UIProcess/API/qt/tests/qwkhistory/tst_qwkhistory.cpp:219
> +    QCOMPARE(testItem->url().toString(), currentItem.url().toString());

Comparing the two QUrl() would be better. Here and in a few places.