[webkit-reviews] review requested: [Bug 61746] [efl] Add ewk API to enable/disable developer extras. : [Attachment 95370] Patch

[bugzilla-daemon at webkit.org]

Lucas De Marchi <demarchi at webkit.org> has asked  for review:
Bug 61746: [efl] Add ewk API to enable/disable developer extras.
https://bugs.webkit.org/show_bug.cgi?id=61746

Attachment 95370: Patch
https://bugs.webkit.org/attachment.cgi?id=95370&action=review

------- Additional Comments from Lucas De Marchi <demarchi at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95370&action=review

Otherwise, looks good

> Source/WebKit/efl/ewk/ewk_view.cpp:2716
> +Eina_Bool ewk_view_setting_enable_developer_extras_set(Evas_Object* o,
Eina_Bool enable)
> +{
> +    EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
> +    EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
> +    if (priv->settings.enable_developer_extras != enable) {

Since this is EAPI and Eina_Bool could assume values other than 1 and 0, a
protection is needed for the enable argument. See 
ewk_view_setting_enable_scripts_set() as an example.