[webkit-reviews] review granted: [Bug 59318] [GTK] Initial tooltips implementation for WebKit2 : [Attachment 95334] Patch updated to current git master

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 59318: [GTK] Initial tooltips implementation for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59318

Attachment 95334: Patch updated to current git master
https://bugs.webkit.org/attachment.cgi?id=95334&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95334&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:295
> +    if (keyboardMode) {
> +	   notImplemented();
> +	   return FALSE;
> +    }

This is for tooltips triggered by keyboard events, right? Is there a bug for
this? If so it's probably best to leave the bug link in a comment.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:361
> +    if (tooltip && *tooltip != '\0') {

I think it's clearer to use tooltip[0] here.