[webkit-reviews] review granted: [Bug 61725] [GTK] Implement JavaScript dialogs in MiniBrowser : [Attachment 95332] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 61725: [GTK] Implement JavaScript dialogs in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=61725

Attachment 95332: Patch
https://bugs.webkit.org/attachment.cgi?id=95332&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95332&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:191
> +    char *buffer = (char *)g_malloc(length * sizeof(char));

You can omit sizeof(char) here. I'm pretty sure it's always one in C. Please
put a space after the cast.

> Tools/MiniBrowser/gtk/BrowserWindow.c:460
> +    WKStringRef retval = (gtk_dialog_run(GTK_DIALOG(dialog)) ==
GTK_RESPONSE_OK) ?
WKStringCreateWithUTF8CString(gtk_entry_get_text(GTK_ENTRY(entry))) : 0;

-> returnValue