[webkit-reviews] review granted: [Bug 61715] Controls never hide in full screen after user stops moving mouse : [Attachment 95316] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted  review:
Bug 61715: Controls never hide in full screen after user stops moving mouse
https://bugs.webkit.org/show_bug.cgi?id=61715

Attachment 95316: Patch
https://bugs.webkit.org/attachment.cgi?id=95316&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95316&action=review

OK, then assuming you tested enough, r=me

> Source/WebCore/html/shadow/MediaControlRootElement.h:99
> +    bool shouldHideControls();

Should this be marked virtual?

> Source/WebCore/html/shadow/MediaControls.h:71
> +    virtual bool shouldHideControls() = 0;

I see only one derived class implementing this. Will having this new pure
virtual function break the build?