[webkit-reviews] review denied: [Bug 61715] Controls never hide in full screen after user stops moving mouse : [Attachment 95316] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 29 19:59:06 PDT 2011
Darin Adler <darin at apple.com> has denied Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 61715: Controls never hide in full screen after user stops moving mouse
https://bugs.webkit.org/show_bug.cgi?id=61715
Attachment 95316: Patch
https://bugs.webkit.org/attachment.cgi?id=95316&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95316&action=review
> Source/WebCore/html/HTMLMediaElement.cpp:2420
> + if (mediaControls()->shouldHideControls())
> + startHideFullscreenControlsTimer();
Mousing over means we should *stop* the timer.
> Source/WebCore/html/HTMLMediaElement.cpp:2424
> m_mouseOver = false;
> + stopHideFullscreenControlsTimer();
Mousing out means we should *start* the timer.
More information about the webkit-reviews
mailing list