[webkit-reviews] review denied: [Bug 61715] Controls never hide in full screen after user stops moving mouse : [Attachment 95314] [PATCH] Fix v2

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 61715: Controls never hide in full screen after user stops moving mouse
https://bugs.webkit.org/show_bug.cgi?id=61715

Attachment 95314: [PATCH] Fix v2
https://bugs.webkit.org/attachment.cgi?id=95314&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95314&action=review

This is missing the mouseover and mouseout part. I see no reason to land the
partial fix.

> Source/WebCore/html/HTMLMediaElement.cpp:2417
>		       mediaControls()->makeOpaque();

We should stop the timer here, when we move over the controls.

> Source/WebCore/html/HTMLMediaElement.cpp:2419
>		   m_mouseOver = false;

And we should start the timer here.