[webkit-reviews] review denied: [Bug 61662] [Chromium] Rendering to resized canvas fails with accelerated 2d canvas : [Attachment 95212] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 29 12:05:03 PDT 2011


James Robinson <jamesr at chromium.org> has denied Justin Novosad
<junov at chromium.org>'s request for review:
Bug 61662: [Chromium] Rendering to resized canvas fails with accelerated 2d
canvas
https://bugs.webkit.org/show_bug.cgi?id=61662

Attachment 95212: Patch
https://bugs.webkit.org/attachment.cgi?id=95212&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
updateCompositorResources() does stuff in the compositor context, but that
should not effect anything.  It also does a flush() on the grContext and a
flush() on the canvas' context.  I suspect that you need one of those to
happen.

You also need to construct a test case for this to guard against future
regressions.


More information about the webkit-reviews mailing list