[webkit-reviews] review denied: [Bug 61683] Convert editing/pasteboard/4861010 to dump-as-markup : [Attachment 95251] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Annie Sullivan
<sullivan at chromium.org>'s request for review:
Bug 61683: Convert editing/pasteboard/4861010 to dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=61683

Attachment 95251: Patch
https://bugs.webkit.org/attachment.cgi?id=95251&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95251&action=review

(In reply to comment #2)
> Note: When I was working on this patch, I noticed that the behavior is no
longer what the test describes ("DragMe" gets inserted after "DropAboveMe", not
before). The behavior changed in changeset 24255. I updated the description,
but is this test still valid? If not, I can delete it instead of updating it.

I don't think we should remove this test since it's one of very few tests that
test drag & drop.

Also, would you mind renaming the file to something more descriptive?  You can
still include <rdar://4861080> in the test description.

> LayoutTests/editing/pasteboard/4861080-expected.txt:1
> +This tests dropping content into the unwanted space above a list items
content when the content is wrapped in a span.	You should see 'DropAboveMe
DragMe'.

There is no longer unwanted space so we should rephrase this.

> LayoutTests/editing/pasteboard/4861080.html:47
>      eventSender.mouseUp();

The statements that compute dropx and dropy seem wrong.  We should get rid of
li.offsetParent.offset*.