[webkit-reviews] review granted: [Bug 61692] REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL : [Attachment 95275] proposed fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 61692: REGRESSION (r85375): Load event is sometimes lost when multiple
image elements use the same URL
https://bugs.webkit.org/show_bug.cgi?id=61692

Attachment 95275: proposed fix
https://bugs.webkit.org/attachment.cgi?id=95275&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95275&action=review

> Source/WebCore/html/HTMLImageElement.h:76
> +    bool hasPendingActivity() const;

I’m not sure it’s useful to have this separate function any more if it’s really
the same as !haveFiredLoadEvent. Is this a virtual function? Is there a reason
callers need to ask this more abstract question instead of asking
haveFiredLoadEvent? Is there a reason this is not inlined?