[webkit-reviews] review granted: [Bug 55585] EWS builds patches that fail to build twice, which seems useless and slows down the bots : [Attachment 95254] Rocking and rolling

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 55585: EWS builds patches that fail to build twice, which seems useless and
slows down the bots
https://bugs.webkit.org/show_bug.cgi?id=55585

Attachment 95254: Rocking and rolling
https://bugs.webkit.org/attachment.cgi?id=95254&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95254&action=review

I don't think you meant to delete all those tests.  Otherwise this looks fine.

> Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:121
> +    def build_style(self):
> +	   return self._build_style

I'm not quite sure why we're doing so much to pipe this through.

> Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:39
>  class AbstractEarlyWarningSystemTest(QueuesTest):

Why are you deleting all these tests?