[webkit-reviews] review denied: [Bug 61603] FEConvolveMatrix::getPixelValue() fails to properly check if y is within bounds, causing it to fail to correctly apply the kernel and edge mode to the first targetY pixels : [Attachment 95252] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Ryan Sleevi
<rsleevi at chromium.org>'s request for review:
Bug 61603: FEConvolveMatrix::getPixelValue() fails to properly check if y is
within bounds, causing it to fail to correctly apply the kernel and edge mode
to the first targetY pixels
https://bugs.webkit.org/show_bug.cgi?id=61603

Attachment 95252: Patch
https://bugs.webkit.org/attachment.cgi?id=95252&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95252&action=review

r-, because of a test issue, but it's easy to fix:

> LayoutTests/svg/filters/feConvolveFilter-y-bounds.svg:7
> +

Patch looks almost perfect, though I'd love to have a comment here stating how
the result should look like.

Even better, you'd maybe include a blue <line> and a green <rect> below, that
looks the same, and add a comment "Both shapes should look identical" (but only
in the file as comment, not as <text> element, to get a cross-platform pixel
test result, if possible).