[webkit-reviews] review denied: [Bug 61680] editing/inserting/insert-3907422 should be dumpAsText test : [Attachment 95242] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Annie Sullivan
<sullivan at chromium.org>'s request for review:
Bug 61680: editing/inserting/insert-3907422 should be dumpAsText test
https://bugs.webkit.org/show_bug.cgi?id=61680

Attachment 95242: Patch
https://bugs.webkit.org/attachment.cgi?id=95242&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95242&action=review

> LayoutTests/editing/inserting/insert-3907422-fix.html:21
> +    var result = root.children[0].nodeName == "BLOCKQUOTE" ? "FAIL" :
"PASS";
> +    document.write(result + ": Buggy code before fix would insert blockquote
after body element in second paste");

I don't think this is the correct check.  The bug was that the node was
inserted AFTER body, not inside body.  In general, it's not a good idea to have
a speculative PASS/FAIL like this unless you reverted the fix and confirmed
that the test prints FAIL.