[webkit-reviews] review granted: [Bug 61679] screen.width and screen.height are stale after screen resize on Chromium Linux : [Attachment 95236] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 27 18:02:30 PDT 2011


Tony Chang <tony at chromium.org> has granted Daniel Erat <derat at chromium.org>'s
request for review:
Bug 61679: screen.width and screen.height are stale after screen resize on
Chromium Linux
https://bugs.webkit.org/show_bug.cgi?id=61679

Attachment 95236: Patch
https://bugs.webkit.org/attachment.cgi?id=95236&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95236&action=review

> Source/WebKit/chromium/src/x11/WebScreenInfoFactory.cpp:54
> +    XGetGeometry(
> +	   display, root, &rootRet, &x, &y, &width, &height, &border, &depth);

Should you check the return status?


More information about the webkit-reviews mailing list