[webkit-reviews] review granted: [Bug 61201] Audit all uses of KURL::prettyURL : [Attachment 95117] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 27 15:15:19 PDT 2011


Alexey Proskuryakov <ap at webkit.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 61201: Audit all uses of KURL::prettyURL
https://bugs.webkit.org/show_bug.cgi?id=61201

Attachment 95117: Patch
https://bugs.webkit.org/attachment.cgi?id=95117&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95117&action=review

Yes - Safari probably relies upon code in NSURLExtras, which is independent of
KURL.

> Source/WebCore/page/Location.cpp:69
> +    return url.hasPath() ? url.deprecatedString() : url.deprecatedString() +
"/";

Why not add a FIXME link to <https://bugs.webkit.org/show_bug.cgi?id=30225> in
case you don't resolve this immediately?


More information about the webkit-reviews mailing list